Repository navigation
fix: guard normalizeIP against undefined or non-string IP - #472
Open
TalhaHunter101 wants to merge 1 commit into
Open
TalhaHunter101 wants to merge 1 commit into
TalhaHunter101 wants to merge 1 commit into
Conversation
Signed-off-by: Talha Shafeeq <talha.shafeeq.ts@gmail.com>
|
Tested locally on Node 22 and verified across the test suite. Key points verified:
|
Puppo
reviewed
Nov 10, 2026
Puppo
left a comment
Puppo
left a comment
Member
There was a problem hiding this comment.
Overall, LGTM — thanks for the fix! One non-blocking test suggestion below.
| t.assert.deepStrictEqual(res1.statusCode, 200) | ||
|
|
||
| const res2 = await fastify.inject({ method: 'GET', url: '/' }) | ||
| t.assert.deepStrictEqual(res2.statusCode, 200) |
Member
There was a problem hiding this comment.
[Suggestion] Could we also send a third request and assert 429 (updating the assertion plan)? The two 200 responses cover the crash fix; the third would verify that requests without an IP still share an enforced rate limit. I checked this locally and the current implementation returns 200, 200, 429.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #471
What kind of change does this PR introduce?
Description
In
index.js,normalizeIPassumed thatipis always a valid string. Whenreq.ipisundefined(which can occur on Unix domain sockets wheresocket.remoteAddressis undefined, mock/injected requests, or aborted connections):!isIPv6(undefined)evaluated totrue.ip.toLowerCase()threwTypeError: Cannot read properties of undefined (reading 'toLowerCase').This PR:
if (typeof ip !== 'string') return ''innormalizeIPso missing or non-string IPs safely return an empty string key rather than throwing.normalizeIP(undefined)and requests withreq.ip === undefinedare handled gracefully without errors.Checklist
npm test